-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize side nav #428
Reorganize side nav #428
Conversation
If we go this light on the categorization, which I'm ok with, we need to also be smarter about sub-page/sections and look into which components we could probably group into one page. For example, we could group HorizontalRule and Spacer into one "Separators" or something page. Which would then look something like: Layout...
Steps Then we also need to be smart about how we name our sections so that instead of this: we have something like: Data Controls...
Forms groups
KeyPadMenu |
Can we zoom on this one real quick with everyone. Prolly a quick 10 minutes. Some questions
|
Yep, let's zoom. I'm worried that we're getting away from some of the wording that users might look for. Navigation and Components come to mind. Also, we need to fit in the Guidelines. I like the idea for the front page rewrite. Color and Spacing are important, but I feel they are hidden on the front page. We should have a link to them in our left nav bar. I looked at a lot of other design systems. Most collapse. Also, two things we might consider: --Search box at the top of the side nav to search the contents of the nav |
Todo:
|
e4a2c8a
to
13a7213
Compare
@gchaps @snide @cchaos Ready for another look. GuidelinesWriting LayoutAccordion NavigationButton DisplayAvatar FormsCode Editor UtilitiesAccessibility |
I like the buckets. Layout and Display seem very similar to me, as in an arrangement of things. Layout is good, my concern is more with Display. My only suggestion is App Layout and Data Display, but I know there was some concern with "Data" |
13a7213
to
e8a2200
Compare
@gchaps I agree there's some ambiguity there. I'd like to merge this as-is but keep an eye on how people respond to the docs. If there's a lot of confusion let's change the names. |
My edits would be to:
I know we're starting to add more sections back in, but I really liked the idea of separating out the "Feedback/Messaging" elements. Grouping them in with the general "Display content", to me, makes me worried they'd be over-used and incorrectly used. |
@cchaos I moved the Card to Display, but I've left the naming as-is and left Popover in Layout (I'm on the fence too). Let's let this marinate with people and make changes after people have had some time to try this out and give feedback. |
Ultimately we'll all want something different. Following our normal "tie goes to the runner" mentality, since CJ made the PR, he can own the calls. This is something we can always change later as we see how people respond. |
1f89db3
to
6fcb421
Compare
Fixes #416. I tried to incorporate @gchaps's idea of using as few categories as possible and some of @cchaos's original structure. I'm sure there are a bunch of ways we can make this better so shout 'em out!
Layout
Accordion
BottomBar
Card
Flex
Flyout
Header
HorizontalRule
Modal
Page
Panel
Popover
Spacer
Steps
Tables
TableOfRecords
Tabs
Content
Avatar
Badge
CallOut
Code
DescriptionList
Health
Icons
Image
Loading
Progress
Text
Title
Toast
Tooltip
Data controls
Button
Code Editor
Color Picker
ContextMenu
Expression
FilePicker
FilterGroup
Form
KeyPadMenu
Link
Pagination
SearchBar
SideNav
Utilities
Accessibility
DelayHide
ErrorBoundary
IsColorDark
OutsideClickDetector